Hi Yasumasa,
On 26/06/2020 5:03 pm, Yasumasa Suenaga wrote:
Hi all,
Please review this change.
JBS: https://bugs.openjdk.java.net/browse/JDK-8248379
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248379/webrev.00/
JDK-8242425 introduces to migrate to thread local handshake from VM
operation for GetOwnedMonitorInfo, GetOwnedMonitorStackDepthInfo, and
GetCurrentContendedMonitor JVMTI functions. However it lacks of
validations for thread state and thread oop of the target.
The restoration of these checks, and the explicit checking of the return
value for execute_direct, looks good to me.
Thanks,
David
-----
This change has been tested on submit repo and serviceability/jvmti,
serviceability/jdwp vmTestbase/nsk/jvmti, vmTestbase/nsk/jdi
vmTestbase/nsk/jdwp.
On submit repo, tools/javac/7118412/ShadowingTest.java and
java/foreign/TestMismatch.java were failed
(mach5-one-ysuenaga-JDK-8248379-20200626-0503-12110818). However they do
not seems to be related to this change.
(Both tests have been passed on my Linux AMD64)
Thanks,
Yasumasa
