http://cr.openjdk.java.net/~iignatyev/8249034/webrev.00/
> 1289 lines changed: 2 ins; 652 del; 635 mod; 

Hi all,

could you please review this clean-up which removes `FileInstaller` actions 
from :vmTestbase_nsk_jvmti tests?
from the main issue(8204985):
> all vmTestbase tests have '@run driver jdk.test.lib.FileInstaller . .' to 
> mimic old test harness behavior and copy all files from a test source 
> directory to a current work directory. some tests depend on this step, so we 
> need 1st identify such tests and then either rewrite them not to have this 
> dependency or leave FileInstaller only in these tests.

`ag -l  '@run driver jdk.test.lib.FileInstaller . .' vmTestbase/nsk/jvmti 
vmTestbase/nsk/share/ExceptionCheckingJniEnv xargs -I{} gsed -i '/@run driver 
jdk.test.lib.FileInstaller \. \./d' {}` was used to remove FileInstaller 
actions from all nsk_jvmti tests. 3 tests had dependency on that action:
 - Allocate/alloc001, where alloc001.sh was assuming that alloc001.bash is in 
the current directory. alloc001.sh has been updated to use ${TESTSRC} env 
variable
 - AttachOnDemand/attach002a and scenarios/bcinstr/BI04/bi04t002: both tests 
assumed that newclassXX directory is located in the current directory. the 
tests were fixed by prefixing 'newclassXX' w/ '${test.src}/' which gets 
expanded by PropertyResolvingWrapper

JBS: https://bugs.openjdk.java.net/browse/JDK-8249034
webrev: http://cr.openjdk.java.net/~iignatyev//8249034/webrev.00/
testing: :vmTestbase_nsk_jvmti on linux-x64

Thanks,
-- Igor

Reply via email to