Hi Chris,
LGTM++
Thanks,
Serguei
On 7/27/20 14:45, Alex Menkov wrote:
Hi Chris,
Looks good to me.
--alex
On 07/27/2020 12:11, Chris Plummer wrote:
Ping! This one is pretty easy. I just changed the two tools to no
longer refuse to run on OSX if we are debugging a core file, and
updated the tests to also do a test run on a core file.
thanks,
Chris
On 7/21/20 1:13 PM, Chris Plummer wrote:
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8248882
http://cr.openjdk.java.net/~cjplummer/8248882/webrev.00/index.html
The changes enable PMap and PStack on OSX when debugging a core
file. Unfortunately there appears to be no exposed way to determine
if you are debugging a core file, so I had to rely on clues (certain
lists being empty).
As part of these changes I'm adding core file testing to the two
relevant tests. Also note that for ClhsdbPMap.java I had to tinker
with the list of expected libraries in the output. For core files on
Windows, the nio and net libraries were missing, presumably because
nothing had triggered their loading yet, so I removed them from the
expected output list, and add jli, which seems to always be there.
Also a minor change in CLHSB.java. It was sending a message to
System.err. It makes the test output easier to read if it goes to
System.out.
thanks,
Chris
