Hi Joe,
The update looks okay to me too.
Thanks,
Serguei
On 7/25/20 11:18, Alan Bateman wrote:
On 25/07/2020 18:52, Joe Darcy wrote:
Hello,
I'm not positive serviceability-dev is the best alias for this
review; if not, please direct me elsewhere.
In any case, please review the changes and CSR for:
JDK-8250583: Address reliance on default constructors in
java.management
webrev: http://cr.openjdk.java.net/~darcy/8250583.0/
CSR: https://bugs.openjdk.java.net/browse/JDK-8250584
(This is part of a larger library clean-up effort to remove reliance
on default constructors in the JDK ahead of a new javac lint warning,
JDK-8071961.)
Generally the changes adds a public no-arg constructor equivalent to
the implicit default constructor. In the case of RoleStatus, since it
doesn't seem that the class should have a public constructor at all,
I terminally deprecated the constructor.
serviceability-dev is fine as it has mostly subsumed the jmx-dev list.
The changes look okay to me.
-Alan
