Test should fail in cases 0 and 2 with IllegalThreadStateException if we can enable events. Such failures should be easily identified by reading logs.
Leonid > On Jul 27, 2020, at 10:28 PM, [email protected] wrote: > > Hi Leonid, > > The fix looks good in general. > You missed to explain that the suspend/resume are added to avoid actual > generation of event that cause this issue. > The reason is that these events are not actually required. > > > http://cr.openjdk.java.net/~lmesnik/8244537/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequest/setEnabled/setenabled003.java.frames.html > > <http://cr.openjdk.java.net/~lmesnik/8244537/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequest/setEnabled/setenabled003.java.frames.html> > 316 case 1: > 317 vm.suspend(); > ... > 336 vm.resume(); > > Q: Why is only in case 1 suspend/resume used? > What about cases 0 and 2? > > Thanks, > Serguei > > > On 7/27/20 18:08, Leonid Mesnik wrote: >> Hi >> >> Could you please review following fix which suspends debugger VM while >> enabling/disabling events. >> >> All changed tests fail intermittently getting unexpected events instead of >> breakpoint used for communication between debugger/debuggee VM. The tests >> request different events and verify request's properties but don't >> process/verify events themselves. Test doesn't aware if events are generated >> or not. The vm suspension doesn't affect JDWP native agent and it still >> should get and verify JDWP commands. >> >> webrev: http://cr.openjdk.java.net/~lmesnik/8244537/webrev.00/ >> <http://cr.openjdk.java.net/~lmesnik/8244537/webrev.00/> >> bug: https://bugs.openjdk.java.net/browse/JDK-8244537 >> <https://bugs.openjdk.java.net/browse/JDK-8244537> >> >> >> Leonid >
