Hi Jie,
Could you, please, split the format string in two shorter lines?
Otherwise, it looks okay.
There is no need in another webrev.
Thanks,
Serguei
On 8/4/20 18:38, jiefu(傅杰) wrote:
Could you, please, split the format string in two shorter lines?
Otherwise, it looks okay.
There is no need in another webrev.
Thanks,
Serguei
On 8/4/20 18:38, jiefu(傅杰) wrote:
Thanks Chris and David for your review.
Will push it later.
Best regards,
Jie
From: David Holmes <[email protected]>
Sent: Wednesday, August 5, 2020 9:03 AM
To: jiefu(傅杰); [email protected]
Subject: Re: FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits(Internet mail)My Review still stands. :)
Thanks,
David
On 5/08/2020 1:10 am, jiefu(傅杰) wrote:
> Forward it to serviceability-dev since this issue in the JBS has been
> moved from hotspot/runtime to core-svc/java.lang.management.
>
> Please review it.
>
> Thanks.
>
> Best regards,
>
> Jie
>
> *From: *"jiefu(傅杰)" <[email protected]>
> *Date: *Tuesday, August 4, 2020 at 5:10 PM
> *To: *"[email protected]"
> <[email protected]>
> *Subject: *RFR: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean
> tests fail with hostnames starting from digits
>
> Hi all,
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8251031
>
> Webrev: http://cr.openjdk.java.net/~jiefu/8251031/webrev.00/
>
> Some vmTestbase/nsk/monitoring/RuntimeMXBean tests failed in our test
> infrastructure.
>
> The reason is that these tests reject hostnames starting with digits.
>
> However, hostnames starting from digits are actually valid according to
> RFC1123 [1][2].
>
> It would be better to fix it.
>
> Thanks a lot.
>
> Best regards,
>
> Jie
>
> [1] https://tools.ietf.org/html/rfc1123#page-13
>
> [2] https://en.wikipedia.org/wiki/Hostname
>
