$ do_java_test -c fastdebug serviceability/sa 2>&1 | tee do_java_test.8251121.log
INFO: GNUMAKE=make
INFO: GNUMAKE version is: GNU Make 3.81

INFO: JTREG options:
INFO:   JOBS=1
INFO:   TEST_MODE=othervm
INFO:   VM_OPTIONS=
INFO: test_val=serviceability/sa
Test Config: macosx-x86_64-normal-server-fastdebug
    INFO: TIMEOUT_FACTOR=6
    Done testing
    Test Run macosx-x86_64-normal-server-fastdebug time: 7.48 minutes.

    TEST                                              TOTAL  PASS FAIL ERROR
    jtreg:open/test/hotspot/jtreg/serviceability/sa      54 54     0     0

Total test time: 7.48 minutes.

660 2020.08.06 14:10:36 $ ls -l /cores

661 2020.08.06 14:19:18 $


When I have done this test run before, I always had 6 core files left.
Now there are none.

Dan


On 8/6/20 1:17 PM, Daniel D. Daugherty wrote:
On 8/5/20 9:16 PM, Chris Plummer wrote:
Hello,

Please review the following:

https://bugs.openjdk.java.net/browse/JDK-8251121
http://cr.openjdk.java.net/~cjplummer/8251121/webrev.00/index.html

test/lib/jdk/test/lib/util/CoreUtils.java
    You might consider two messages with timestamps: one before the move
    and one after the move completes.

test/hotspot/jtreg/serviceability/sa/ClhsdbCDSCore.java
    No comments.

Thumbs up. No need for another webrev if you decide to update the mesgs.

I'm testing your patch on my MBP13 to verify that it solves the issue
that I reported.

Dan



On OSX (and possibly some linux systems), core files are not produced in the cwd, but instead end up in some well known location. For OSX it is the /cores directory. The core files tend to accumulate there. This fixes the core file accumulation problem by moving the core file into the cwd, allowing jtreg to manage it. By default jtreg will delete the core if the test passes, and retain if if the test fails or RETAIN=all is specified.

I got rid of the code in ClhsdbCDSCore.java that explicitly deletes the core file because we don't want it deleted if RETAIN=all is used.

thanks,

Chris


Reply via email to