Re: RFR (S) 8251302: Create dedicated OopStorages for Management and Jvmti

[serguei.spit...@oracle.com]

Hi Coleen,

It looks good to me.
Minor:

+void JvmtiExport::initialize_oop_storage() {
+  // OopStorage needs to be created early in startup and unconditionally
+  // because of OopStorageSet static array indices.
+  _jvmti_oop_storage = OopStorageSet::create_strong("Thread OopStorage");
+}
+

Would it better to replace "Thread Oopstorage" with "JVMTI Oopstorage"?
No need in another webrev.

Thanks,
Serguei

On 8/10/20 12:37, Coleen Phillimore wrote:

These OopHandles are created and released during breakpoints and Thread stack walking operations.  They should have their own OopStorage so that GC can detect whether these things affect timing.

Tested with tier1-6.

open webrev at http://cr.openjdk.java.net/~coleenp/2020/8251302.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8251302

Thanks,
Coleen