Hi Alex,
Yes, of course, there are more tests depending on JVMTI in the
vmTestbase, jdk_jdi and jdk_instrument.
Just wanted to point that the test/hotspot/jtreg/compiler and
test/hotspot/jtreg/runtime also have such tests.
I wonder if there is any enhancement filed to cover all needs.
One question is:
Do we really want to update each nsk test depending on JVMTI or there
is a way to solve it on the test suite level?
Here we may need some recommendation from Igor.
Thanks,
Serguei
On 8/20/20 11:50, Alex Menkov wrote:
Hi Serguei,
On 08/19/2020 20:34, [email protected] wrote:
Hi Alex,
It looks good to me.
But there are more tests in test/hotspot/jtreg/runtime and
test/hotspot/jtreg/compiler which use the Instrumentation API, and
so, depend on the JVMTI.
Examples are:
test/hotspot/jtreg/compiler/jsr292
test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test
test/hotspot/jtreg/compiler/profiling/spectrapredefineclass
test/hotspot/jtreg/runtime/Metaspace/DefineClass.java
test/hotspot/jtreg/runtime/cds/appcds/cacheObject
test/hotspot/jtreg/runtime/cds/appcds/javaldr
test/hotspot/jtreg/runtime/cds/appcds/jvmti
test/hotspot/jtreg/runtime/records
test/hotspot/jtreg/runtime/sealedClasses
I wonder if you are aware about these tests and have any plan for them.
Looks like you missed this:
>> and updates tests in test/hotspot/jtreg/serviceability/jvmti (the only
>> change in all tests is added "@requires vm.jvmti")
>> Other tests will be updated in the follow-ups.
The are many tests which needs to be updated in test/hotspot and test/jdk
--alex
Thanks,
Serguei
On 8/19/20 18:02, Alex Menkov wrote:
Hi all,
please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8251384
webrev:
http://cr.openjdk.java.net/~amenkov/jdk16/minimal_jvmti/webrev/
The fix introduces new @requires option "vm.jvmti":
test/lib/sun/hotspot/WhiteBox.java
test/jtreg-ext/requires/VMProps.java
src/hotspot/share/prims/whitebox.cpp
test/hotspot/jtreg/TEST.ROOT
and updates tests in test/hotspot/jtreg/serviceability/jvmti (the
only change in all tests is added "@requires vm.jvmti")
Other tests will be updated in the follow-ups.
The
