On 9/18/20 1:59 PM, Serguei Spitsyn wrote:
On Fri, 18 Sep 2020 20:23:15 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
In the platform-specific implementations of linker_md.c, we see the
dll_build_name methods begin with a call to
jvmtiAllocate.
We then appear to rush ahead and try to use that variable without checking for
a null.
I propose moving the null check to the point *before* we try to use that
variable, to avoid any possible SEGV.
Bug link: https://bugs.openjdk.java.net/browse/JDK-8252997
Both files need copyright updates before pushing. Otherwise the changes look
good.
The fix looks okay to me.
But I have a dejavu that I've already reviewed it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/246
Serguei, it was initially was sent out as a non-GIT review even though
we had transitioned to GIT. Dan asked that it be moved to GIT. So like
me, you probably looked at the changes but didn't send out an official
"reviewed" email since it still needed to be moved to GIT.
Chris
