On Mon, 21 Sep 2020 21:19:32 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev >> excludes the unrelated changes brought in by the merge/rebase. The pull >> request contains five additional commits since >> the last revision: >> - Update after Dan and David >> - Merge branch 'master' into 8238761-asynchrounous-handshakes >> - Removed double check, fix comment, removed not needed function, updated >> logs >> - Fixed double checks >> Added NSV >> ProcessResult to enum >> Fixed logging >> Moved _active_handshaker to private >> - Rebase version 1.0 > > src/hotspot/share/runtime/handshake.hpp line 78: > >> 76: FilterQueue<HandshakeOperation*> _queue; >> 77: Mutex _lock; >> 78: Thread* _active_handshaker; > > Nit: can you line up the data member names for lock and _active_handshaker ? FilterQueue<HandshakeOperation*> _queue; JavaThread* _handshakee; Mutex _lock; Thread* _active_handshaker; Isn't this nicer? (it didn't keep the formatting in the comment) ------------- PR: https://git.openjdk.java.net/jdk/pull/151
