On Wed, 23 Sep 2020 04:06:46 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update after Coleen > > src/hotspot/share/utilities/filterQueue.hpp line 56: > >> 54: } >> 55: >> 56: // MT-safe > > Not sure where our previous discussion is on this but these posix-style > MT-safe labels don't really halp for this kind > of abstract data type API. Please briefly explain the thread-safety > properties of add and pop. Added comment > src/hotspot/share/utilities/filterQueue.hpp line 57: > >> 55: >> 56: // MT-safe >> 57: void add(E data); > > It would be more regular naming to use add/remove or push/pop rather than > add/pop. Change to push. ------------- PR: https://git.openjdk.java.net/jdk/pull/151
