On Wed, 23 Sep 2020 05:35:29 GMT, Aleksey Shipilev <[email protected]> wrote:
>> the patch
>> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/aod` tests
>> - updates `AODRunnerArgParser` to remove surrounding `"` symbols from
>> `javaOpts` option values
>> - updates vmTestbase/nsk/aod test descriptions to have `"` in `javaOpts`
>> values (as opposed of around `-javaOpts=$value`
>> as it's now)
>> - mechanically reformats/cleans up the tests (whitespaces, imports, etc)
>>
>> testing:
>> * [x] vmTestbase/nsk/aod on {macosx,windows,linux}-x64
>> * [x] vmTestbase/nsk/aod on macosx-x64 w/ `VM_OPTIONS`, `JAVA_OPTIONS` being
>> empty and having value
>
> Looks good, modulo minor comments below.
@shipilev , @sspitsyn, thanks for your reviews.
-------------
PR: https://git.openjdk.java.net/jdk/pull/311
