On Wed, 23 Sep 2020 03:34:29 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
>> Co-authored-by: Vicente Romero <vicente.rom...@oracle.com> >> Co-authored-by: Harold Seigel <harold.sei...@oracle.com> >> Co-authored-by: Jonathan Gibbons <jonathan.gibb...@oracle.com> >> Co-authored-by: Brian Goetz <brian.go...@oracle.com> >> Co-authored-by: Maurizio Cimadamore <maurizio.cimadam...@oracle.com> >> Co-authored-by: Joe Darcy <joe.da...@oracle.com> >> Co-authored-by: Chris Hegarty <chris.hega...@oracle.com> >> Co-authored-by: Jan Lahoda <jan.lah...@oracle.com> > > Vicente Romero has updated the pull request incrementally with three > additional commits since the last revision: > > - Merge pull request #1 from ChrisHegarty/record-serial-tests > > Remove preview args from JDK tests > - Remove preview args from ObjectMethodsTest > - Remove preview args from record serialization tests Marked as reviewed by chegar (Reviewer). test/langtools/tools/javac/records/LocalStaticDeclarations.java line 33: > 31: * jdk.compiler/com.sun.tools.javac.util > 32: * @build combo.ComboTestHelper > 33: * @compile LocalStaticDeclarations.java This, and other, explicit at compile tags could be elided, no? The test source file will be implicitly compiled by the at run tag. I believe that the explicit at compile tag was added original so that the enable preview and source version options could be passed to javac - neither of which are needed any more. ------------- PR: https://git.openjdk.java.net/jdk/pull/290
