On Wed, 30 Sep 2020 18:47:36 GMT, Igor Ignatyev <iignat...@openjdk.org> wrote:
> separating the commit from #370 / > [8252003](https://bugs.openjdk.java.net/browse/JDK-8253872)[[1]] > > jvmti_tools.cpp supports ` `, `~` and/or `,` as delimiters[[2]] in -agentlib > options, but > `nsk/share/jvmti/ArgumentHandler` takes these options (via > `getAgentOptionsString`) and then parse in > `parseOptionString`, where `StringTokenizer` is used w/ default delimiters, > ie `\t\n\r\f`, and as a result, it doesn't > split options correctly in tests which use delimiters other than ` `. and in > fact, > `nsk/jvmti/scenarios/contention/TC05/tc05t001` is using `,` and gets wrong > options/values. testing: ✅ > `nsk/jvmti/scenarios/contention/TC05/tc05t001` [1]: > https://github.com/openjdk/jdk/pull/370/commits/5219b11650c00f9af5564758b3292458a48e7f21#r497658983 > [2]: > https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp#L224 This pull request has now been integrated. Changeset: 4b16f8ab Author: Igor Ignatyev <iignat...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/4b16f8ab Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8253872: ArgumentHandler must use the same delimiters as in jvmti_tools.cpp Reviewed-by: cjplummer ------------- PR: https://git.openjdk.java.net/jdk/pull/438
