On Thu, 1 Oct 2020 15:02:55 GMT, Chris Plummer <[email protected]> wrote:
>>> I think this fix deserves a new JBS issue. It doesn't resolve the rounding >>> problem described in JDK-8230664. It fixes >>> an additional issue. The rounding problem may reoccur when other class >>> layout changes are done. >> >> Totally agreed. But, would you mind to create the ticket for me, please? >> Then, I change the commit header/message. >> Thank you!! > >> I think this fix deserves a new JBS issue. It doesn't resolve the rounding >> problem described in JDK-8230664. It fixes >> an additional issue. The rounding problem may reoccur when other class >> layout changes are done. > > Does it still need to be problem listed due to this issue? I guess it may or > may not be an issue based on the current > size InstanceKlass, so probably best to keep in problem listed. If these tests are currently passing with Jose's fix, I suggest to comment them out in the problem list with a note that we may need to disable them again because of JDK-8230664. This way we can test the functionality Jose is fixing until then. And we'll see when the issue comes up again. ------------- PR: https://git.openjdk.java.net/jdk/pull/358
