On Tue, 13 Oct 2020 12:48:05 GMT, Richard Reingruber <[email protected]> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Review 1
>
> Hi Stefan,
> 
> thanks for fixing.
> 
> With this change the assertion in pr #119 does not fail anymore.
> 
> The fix looks good to me but I'm not an ZGC expert, neither a Reviewer :)

Thanks @fisk and @reinrich for reviewing.

> src/hotspot/share/prims/jvmtiEnvBase.cpp line 559:
> 
>> 557:
>> 558: // return the vframe on the specified thread and depth, NULL if no such 
>> frame
>> 559: // The thread and the oops in the returned might not have been process.
> 
> s/the returned/the returned vframe/

Thanks for noticing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/627

Reply via email to