On Fri, 16 Oct 2020 22:30:14 GMT, Markus Grönlund <mgron...@openjdk.org> wrote:
> Greetings, > > JDK-8243962 has been a large effort to chase down intermittent timeouts for > certain JVMTI tests when run on Windows > debug builds in combination with JFR. The background is long, included in > JDK-8243962. > In short, the combination of some JVMTI thread suspension tests when run > together with JFR on saturated Windows 2016 > debug builds can intermittently time out. > There have been two major changes made to JFR derived from JDK-8243962 > (linked therein) in an attempt to reduce the > poor scalability observed. > Unfortunately, the efforts have not fully resolved the situation entirely as > there have still been intermittent > sightings for the following tests: > vmTestbase/nsk/jvmti/scenarios/sampling/SP04/sp04t002/TestDescription.java > vmTestbase/nsk/jvmti/scenarios/sampling/SP04/sp04t001/TestDescription.java > vmTestbase/nsk/jvmti/scenarios/sampling/SP03/sp03t001/TestDescription.java > vmTestbase/nsk/jvmti/scenarios/sampling/SP03/sp03t002/TestDescription.java > > This change will add a requires expression to these tests to exclude the > combination of running them with JFR on > Windows debug builds. > Thanks > Markus Hi Markus, I'd suggest to simplify the requires statement from: + * @requires !vm.flightRecorder | !(vm.debug & os.family == "windows") to: + * @requires !vm.flightRecorder | !vm.debug | os.family != "windows" Thanks, Serguei ------------- PR: https://git.openjdk.java.net/jdk/pull/712
