On Tue, 10 Nov 2020 20:57:48 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> dholmes-ora - convert inner while loop to do-while loop in >> unlink_deflated(). > > src/hotspot/share/runtime/synchronizer.hpp line 28: > >> 26: #define SHARE_RUNTIME_SYNCHRONIZER_HPP >> 27: >> 28: #include "logging/logStream.hpp" > > If you need to put MonitorList in the header file, use a forward declaration > for LogStream instead of #including logstream.hpp. I can see if that will work. > src/hotspot/share/runtime/objectMonitor.hpp line 171: > >> 169: volatile int _SpinDuration; >> 170: >> 171: jint _contentions; // Number of active contentions in >> enter(). It is used by is_busy() > > Future RFE - can we replace jint with int32_t or even int or some C++ types. > We're trying not to have Java types leak into runtime code since this doesn't > directly interface with Java. It can be a future RFE, but it won't be at the top of my list of things to do. There may already be an RFE for that. ------------- PR: https://git.openjdk.java.net/jdk/pull/642
