On Wed, 18 Nov 2020 19:55:48 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> I think you need to add a test case. You can use the work done for > JDK-8237354 dcmd as a template. See > http://cr.openjdk.java.net/~rschmelter/webrevs/8237354/webrev.3/. I don't > know that's it's necessary to add a test case for each GC, but if you do, I > suggest putting them all in one file. The use of separate files per test case > was not necessary. I extended the BasicJMapTest.java to test the compressed heap dump. would you like to help review? Thanks! ------------- PR: https://git.openjdk.java.net/jdk/pull/1251
