On Tue, 1 Dec 2020 20:12:28 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Merge branch 'master' into mprotect >> - Made resexhaused001.004 manual tests. You can't reliably run these tests. >> - 8253916: ResourceExhausted/resexhausted001 crashes on Linux-x64 > > src/hotspot/share/runtime/stackOverflow.cpp line 109: > >> 107: } >> 108: >> 109: log_debug(os, thread)("Thread " UINTX_FORMAT " stack guard pages >> activated: " > > I always was curious about this uncommit. I wondered whether it was a > fallback for platforms where mprotect would not work on thread stacks. But > then, why warn unconditionally? Maybe the uncommit was an attempt to achieve the same thing as protecting the pages, ie get a SEGV when accessing them. I don't know either. ------------- PR: https://git.openjdk.java.net/jdk/pull/1540