Hi,

Please review the following small fix for test 
RemovingUnixDomainSocketTest.java. As explained in the bug comments, the issue 
is due to having two different StreamPumper objects consuming from the same 
stderr, one created by ProcessTools.startProcess() and another by 
OutputAnalyzer(). In the failing cases the StreamPumper processing thread 
created in ProcessTools.startProcess() consumes the first part of the 
deprecation message while the one created in OutputAnalyzer consumes the rest. 
Since out.getStderr() is not empty and does not contain the string "VM 
warning:", the test fails.

I simply replaced the ProcessTools.startProcess() call by a call to start() on 
the ProcessBuilder object, which doesn't use StreamPumper. I added 
stderrShouldBeEmptyIgnoreDeprecatedWarnings(), since as mentioned in 8248162 we 
might not want to hide all warning messages.

Without the patch I can consistently reproduce the issue. With the patch the 
test always passes.

Thanks,
Patricio

-------------

Commit messages:
 - v1

Changes: https://git.openjdk.java.net/jdk/pull/1749/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1749&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8258057
  Stats: 20 lines in 2 files changed: 18 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/1749.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/1749/head:pull/1749

PR: https://git.openjdk.java.net/jdk/pull/1749

Reply via email to