On Wed, 16 Dec 2020 07:40:18 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> This change have been already reviewed by Mandy, Sundar, Alan and David. >> Please, see the jdk 15 review thread: >> >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html >> >> Now, the PR approval is needed. >> The push was postponed because the CSR was not approved at that time (it is >> now): >> https://bugs.openjdk.java.net/browse/JDK-8248189 >> Investigation of existing popular java agents was requested by Joe. >> ---------- >> >> The java.lang.instrument spec: >> >> https://docs.oracle.com/en/java/javase/15/docs/api/java.instrument/java/lang/instrument/package-summary.html >> >> Summary: >> The java.lang.instrument spec clearly states: >> "The agent class must implement a public static premain method >> similar in principle to the main application entry point." >> Current implementation of sun/instrument/InstrumentationImpl.java >> allows the premain method be non-public which violates the spec. >> This fix aligns the implementation with the spec. >> >> Testing: >> A mach5 run of jdk_instrument tests is in progress. > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > fixed trailing spaces test/jdk/java/lang/instrument/AgentJarBuilder.java line 36: > 34: import jdk.test.lib.util.JarUtils; > 35: > 36: public class AgentJarBuilder { Can you use the test library `test/lib/jdk/test/lib/util/JavaAgentBuilder.java`? test/jdk/java/lang/instrument/PremainClass/InheritAgent0010.java line 32: > 30: * @library /test/lib > 31: * @library /test > 32: * @modules jdk.jartool/sun.tools.jar I don't see `sun.tools.jar` is used. Is this qualified exports needed? ------------- PR: https://git.openjdk.java.net/jdk/pull/1694
