On Wed, 6 Jan 2021 16:53:55 GMT, Daniel D. Daugherty <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix copyrights. > > src/hotspot/share/runtime/deoptimization.cpp line 153: > >> 151: >> 152: // In order to make fetch_unroll_info work properly with escape >> 153: // analysis, The method was changed from JRT_LEAF to JRT_BLOCK_ENTRY. > > nit - typo (not yours): s/, The/, the/ I fixed this and noticed that just under it is a comment that is now false with this change, so deleted it too. > src/hotspot/share/runtime/handles.hpp line 292: > >> 290: >> 291: // ResetNoHandleMark is called in a context where there is an enclosing >> 292: // NoHandleMark. Thread in _thread_in_native cannot create handles so > > Perhaps: > // NoHandleMark. A thread in _thread_in_native must not create handles so Ok, "must not" is better since it's more strict. > src/hotspot/share/runtime/handles.hpp line 293: > >> 291: // ResetNoHandleMark is called in a context where there is an enclosing >> 292: // NoHandleMark. Thread in _thread_in_native cannot create handles so >> 293: // this is used when transitioning via. ThreadInVMfromNative. > > nit typo: s/via./via/ ok ------------- PR: https://git.openjdk.java.net/jdk/pull/1846
