On Wed, 13 Jan 2021 04:25:33 GMT, David Holmes <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix wrong JavaThread::active in fill_in_stack_trace.
>
> Hi Coleen,
>
> This all seems fine to me. One minor nit below.
>
> Thanks,
> David
Thanks David - thank you for asking about JavaThread::active so we could find
this bug.
> src/hotspot/share/utilities/preserveException.cpp line 32:
>
>> 30:
>> 31: PreserveExceptionMark::PreserveExceptionMark(Thread* thread) {
>> 32: _thread = thread;
>
> Nit: extra spaces before = now that lines are not being aligned.
fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2007
