On Mon, 18 Jan 2021 23:06:07 GMT, David Holmes <[email protected]> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Merge test files into one
>> - Adress review feedback from dholmes
>> - Merge branch 'master' into JDK-8258836-check-jni-mbeanserver
>> - 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo
>
> src/jdk.management/share/native/libmanagement_ext/DiagnosticCommandImpl.c
> line 189:
>
>> 187: cmd,
>> 188:
>> dcmd_info_array[i].num_arguments);
>> 189: if (args == NULL) {
>
> Aren't you missing the PopLocalFrame for this return path?
Thanks, David. Added a call to `PopLocalFrame` here and in various other places
where we have a short return.
> src/jdk.management/share/native/libmanagement_ext/DiagnosticCommandImpl.c
> line 214:
>
>> 212: if (obj == NULL) {
>> 213: free(dcmd_info_array);
>> 214: return NULL;
>
> Again aren't you missing the PopLocalFrame on this return path?
Fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2130
