Hi Chris, thank you for your review.
Per your request/recommendation, I'll cross-post to hotspot-compiler-dev. On the other hand, I've been working recently in just that corner of CodeHeap/CodeCache. As the access to VM data structures via AsyncGetCallTrace() is asynchronous (the name suggests it), you may see inconsistent states. You have to deal with such inconsistencies. Furthermore, a direct colleague of mine did in-depth research on Async Profiler. I consulted with him. Anyway, thanks again! Lutz On 19.01.21, 23:26, "hotspot-dev on behalf of Chris Plummer" <[email protected] on behalf of [email protected]> wrote: On Mon, 11 Jan 2021 18:39:41 GMT, Lutz Schmidt <[email protected]> wrote: > Hi, > may I please ask the community to review this small fix? It closes another hole in AsyncGetCallTrace(). > Thanks a lot! > Lutz The changes look ok to me. I think it would be good to get someone from the compiler team to verify your reasoning here. ------------- Marked as reviewed by cjplummer (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2032
