On Wed, 20 Jan 2021 21:20:43 GMT, Chris Plummer <[email protected]> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8258836-check-jni-mbeanserver
>> - Actually assign the variable returned from PopLocalFrame
>> - Merge test files into one
>> - Adress review feedback from dholmes
>> - Merge branch 'master' into JDK-8258836-check-jni-mbeanserver
>> - 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo
>
> src/jdk.management/share/native/libmanagement_ext/DiagnosticCommandImpl.c
> line 194:
>
>> 192:
>> dcmd_info_array[i].num_arguments);
>> 193: if (args == NULL) {
>> 194: (*env)->PopLocalFrame(env, NULL);
>
> You actually need 2 PopLocalFrame calls here. One to match the PushLocalFrame
> inside this loop, and one to match the PushLocalFrame outside the loop.
Fixed.
> src/jdk.management/share/native/libmanagement_ext/DiagnosticCommandImpl.c
> line 218:
>
>> 216: args);
>> 217: if (obj == NULL) {
>> 218: (*env)->PopLocalFrame(env, NULL);
>
> And 2 here also.
Fixed.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2130
