On Fri, 22 Jan 2021 20:18:51 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > > make/autoconf/flags-cflags.m4 line 169: > >> 167: WARNINGS_ENABLE_ALL="-Wall -Wextra -Wformat=2 >> $WARNINGS_ENABLE_ADDITIONAL" >> 168: >> 169: DISABLED_WARNINGS="unknown-warning-option unused-parameter unused >> format-nonliteral" > > Globally disabling a warning needs some motivation. Why is this needed? Does > it really need to be applied everywhere or is there a specific binary or > source file where this is triggered? It seems to be a leftover from the past. I tried to revert the line and the build went fine. Thanks for noticing! ------------- PR: https://git.openjdk.java.net/jdk/pull/2200
