On Mon, 1 Feb 2021 14:06:32 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>>> Hello, hsdis is a separate out-of-tree project and is not part of this jep. >> >> Unless there's something I'm missing it only requires a few lines of change >> to src/utils/hsdis/makefile (it already has support for macos x86_64) >> >>>support for looking for proper hsdis dylib library was added as part of this >>>jep. >> >> I'm a little confused. Are you planning on adding a new disassembler? > >> > Hello, hsdis is a separate out-of-tree project and is not part of this jep. >> >> Unless there's something I'm missing it only requires a few lines of change >> to src/utils/hsdis/makefile (it already has support for macos x86_64) > > I agree with Alan that it makes sense to add this trivial change as part of > this PR, if it allows the current hsdis solution to continue working on > mac/aarch64. > >> >> > support for looking for proper hsdis dylib library was added as part of >> > this jep. >> >> I'm a little confused. Are you planning on adding a new disassembler? > > @a74nh I think Vladimir is referring to > https://github.com/openjdk/jdk/pull/392. The hsdis "component" has been left > behind for a long time, and there are several requests to add new backends, > which require a modernized build of hsdis. This is undfortunately not a > high-priority project, and has been postponed several times already. :( > > > Hello, hsdis is a separate out-of-tree project and is not part of this > > > jep. > > > > > > Unless there's something I'm missing it only requires a few lines of change > > to src/utils/hsdis/makefile (it already has support for macos x86_64) > > I agree with Alan that it makes sense to add this trivial change as part of > this PR, if it allows the current hsdis solution to continue working on > mac/aarch64. > > > > support for looking for proper hsdis dylib library was added as part of > > > this jep. > > > > > > I'm a little confused. Are you planning on adding a new disassembler? > > @a74nh I think Vladimir is referring to #392. The hsdis "component" has been > left behind for a long time, and there are several requests to add new > backends, which require a modernized build of hsdis. This is undfortunately > not a high-priority project, and has been postponed several times already. :( Sorry I was under impression hsdis is not part of openjdk tree. Alan, could you please share with us the version of binutils you were using in your test ? Regards, Vladimir ------------- PR: https://git.openjdk.java.net/jdk/pull/2200
