On Tue, 2 Feb 2021 11:20:30 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary CreateCoredumpOnCrash > > Hi Thomas, > The fix looks good. Thank you fixing it. > I've submitted mach5 test job with 40 runs of the > java/lang/instrument/PremainClass tests. > All are passed while they were failing before. > Also, David is right, the option -XX:-CreateCoreDumpOnCrash can be removed > from tests: > test/jdk/java/lang/instrument/PremainClass/NoPremainAgent.java > test/jdk/java/lang/instrument/PremainClass/ZeroArgPremainAgent.java > > But I can file a separate bug on it. > Also, I've closed bug https://bugs.openjdk.java.net/browse/JDK-8260469 as a > dup of this one. > > Thanks, > Serguei David, Serguei, thanks for the reviews! I removed the superfluous options and re-ran the affected tests locally, all seemed fine. No cores popped up either. I will wait the 24hrs, then integrate. Cheers, Thomas ------------- PR: https://git.openjdk.java.net/jdk/pull/2332
