On Tue, 2 Feb 2021 20:43:29 GMT, Alex Menkov <[email protected]> wrote:
>> test/jdk/com/sun/jdi/JdbOptions.java line 85: >> >>> 83: private static final String outFilename = >>> UUID.randomUUID().toString() + ".out"; >>> 84: private static final Path outPath = Paths.get(outFilename); >>> 85: private static final String targ = JbdOptionsTarg.class.getName() + >>> " " + outFilename; >> >> Is there a reason you added `outFilename` to `targ` rather than just add >> `outFilename` when you pass the argument string to `test()`. > > Just to minimize the changes as outFilename is required argument for target > app. I think `targ` is typically the classfile name of the target debuggee, so I think it would be best to keep the output filename separate from it to avoid confusion. ------------- PR: https://git.openjdk.java.net/jdk/pull/2322
