On Tue, 2 Feb 2021 18:00:06 GMT, Gerard Ziemski <gziem...@openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   support macos_aarch64 in hsdis
>
> src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp line 390:
> 
>> 388:       store_and_inc(_to, from_obj, NativeStack::intSpace);
>> 389: 
>> 390:       _num_int_args++;
> 
> `pass_byte()` and  `pass_short()` use only one `_num_int_args++;` after the 
> `if else` but other methods use 2 of them inside `if else` branches.
> 
> We should be consistent.

Agree. I'm going to do as much refactoring as needed before this patch under 
JDK-8261071

-------------

PR: https://git.openjdk.java.net/jdk/pull/2200

Reply via email to