On Thu, 28 Jan 2021 22:33:53 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix the logic of using gz= as file name > > You added clhsdb testing to ClhsdbDumpheap.java, but I had also suggested > adding testing to BasicJMapTest.java to test pmap. Can you please add some > testing there also? Hi @plummercj, > I have found that there is a bug in jcmd jmap, it could accept the argument > "gz=" with no value specified. > so jmap -dump:file=a.hprof,gz= could generate dump file successfully. After re-think of it, the jcmd jmap issue mentioned here seems not quite related with this PR, so maybe a standalone one is better? What do you think? ------------- PR: https://git.openjdk.java.net/jdk/pull/1712
