On Tue, 2 Feb 2021 23:21:50 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix issue with parsing 'examine' output when there is unexecptected output >> due to CDS logging or -Xcheck:jni warnings. > > LGTM @YaSuenag and @kevinjwalls I had to make a minor fix to the test. Can you please review it. The issued turned up when I ran some higher test tiers, one of which enabled CDS with some tracing and the other enabled `-Xcheck:jni`, which produced output due to [JDK-8261607](https://bugs.openjdk.java.net/browse/JDK-8261607). Both caused extra output that resulted in improperly parsing the `examine` output and not actually finding that address that it produced. This was because there were lines of output before even issuing the `examine` command that matched the pattern being looked for. I made the pattern more specific by including the tid of the thread. I also cleaned up the comments around that code a bit. thanks. ------------- PR: https://git.openjdk.java.net/jdk/pull/2111
