> Dear community, > may I please request reviews for this fix, improving the usefulness of method > invocation counters. > - aggregation counters are retyped as uint64_t, shifting the overflow > probability way out (185 days in case of a 1 GHz counter update frequency). > - counters for individual methods are interpreted as (unsigned int), in > contrast to their declaration as int. This gives us a factor of two before > the counters overflow. > - as a special case, "compiled_invocation_counter" is retyped as long, > because it has a higher update frequency than other counters. > - before/after sample output is attached to the bug description. > > Thank you! > Lutz
Lutz Schmidt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - expand remaining counters to 64-bit, remove 64 suffix - 8261447: requested changes by TobiHartmann - JDK-8261447: MethodInvocationCounters frequently run into overflow - expand remaining counters to 64-bit, remove 64 duffix - 8261447: requested changes by TobiHartmann - JDK-8261447: MethodInvocationCounters frequently run into overflow ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2511/files - new: https://git.openjdk.java.net/jdk/pull/2511/files/bfd60a3c..67fb3f7d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2511&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2511&range=01-02 Stats: 8620 lines in 332 files changed: 4163 ins; 2472 del; 1985 mod Patch: https://git.openjdk.java.net/jdk/pull/2511.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2511/head:pull/2511 PR: https://git.openjdk.java.net/jdk/pull/2511
