> Hi, Please review > > When debugging for other test case which uses jcmd to attach LingeredApp > process, found there is no error information logged when the app started with > function 'startAppExactJvmOpts' exits due to some reason. This is not > convenient for trace what is the app failure. > This simple fix for adding finishApp to print out error information when > LingeredApp could not start with startAppExactJvmOpts, this is similar to > startApp. > > Tests: This is a simple fix and done tests with test/jdk/sun/tools/jinfo > which uses the function startAppExactJvmOpts to create LingeredApp, also the > test case in debugging, which indeed captured the error message upon start > error. > > Thanks > Yumin
Yumin Qi has updated the pull request incrementally with one additional commit since the last revision: Add a flag to remember finishApp already called ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/2679/files - new: https://git.openjdk.java.net/jdk/pull/2679/files/68a564f5..f8cbc91b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2679&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2679&range=00-01 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2679.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2679/head:pull/2679 PR: https://git.openjdk.java.net/jdk/pull/2679
