On Tue, 23 Feb 2021 21:19:56 GMT, Yumin Qi <[email protected]> wrote:
>> Hi, Please review >> >> When debugging for other test case which uses jcmd to attach LingeredApp >> process, found there is no error information logged when the app started >> with function 'startAppExactJvmOpts' exits due to some reason. This is not >> convenient for trace what is the app failure. >> This simple fix for adding finishApp to print out error information when >> LingeredApp could not start with startAppExactJvmOpts, this is similar to >> startApp. >> >> Tests: This is a simple fix and done tests with test/jdk/sun/tools/jinfo >> which uses the function startAppExactJvmOpts to create LingeredApp, also the >> test case in debugging, which indeed captured the error message upon start >> error. >> >> Thanks >> Yumin > > Yumin Qi has updated the pull request incrementally with one additional > commit since the last revision: > > Remove finishApp from startApp, move printout to startAppExactJvmOpts. Marked as reviewed by cjplummer (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/2679
