On Thu, 25 Feb 2021 03:54:35 GMT, Chris Plummer <[email protected]> wrote:

> This a new test that runs jstack on a process that is busy doing things. It 
> runs jstack 4 times as the process is starting up.

test/jdk/sun/tools/jhsdb/JStackStressTest.java line 91:

> 89:             } else {
> 90:                 System.out.println("Jshell not alive");
> 91:             }

Shouldn't we use `Process::waitFor` at this point to ensure the jshell is 
terminated? This test might not have enough time to shutdown since issuing 
`/exit`.
`destroy()` should be called when timeout is happened at `waitFor()`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2720

Reply via email to