On Mon, 15 Mar 2021 19:20:27 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Koichi Sakata has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix calculation for the length of white space > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/PStack.java line 85: > >> 83: } >> 84: final boolean cdbgCanDemangle = cdbg.canDemangle(); >> 85: String fillerForAddress = " ".repeat(2 + (2 << >> VM.getVM().getLogAddressSize())) + "\t"; > > Why not use `2 * VM.getVM().getAddressSize()` rather than `(2 << > VM.getVM().getLogAddressSize()`? Thank you. I missed that method. I've changed the code. ------------- PR: https://git.openjdk.java.net/jdk/pull/3004
