On Thu, 18 Mar 2021 18:26:20 GMT, Alex Blewitt <github.com+76791+alb...@openjdk.org> wrote:
> As with #2993 changing the order of `final static` to `static final` for the > `java.management`, `java.management.rmi` and `java.naming` modules. Overall good - found a few cases where the private modifier is in the wrong place that ought to be fixed as well. src/java.naming/share/classes/com/sun/jndi/ldap/EventQueue.java line 48: > 46: */ > 47: final class EventQueue implements Runnable { > 48: static final private boolean debug = false; Move private to the front? src/java.naming/share/classes/com/sun/jndi/ldap/EventSupport.java line 116: > 114: */ > 115: final class EventSupport { > 116: static final private boolean debug = false; Move private to the front? src/java.naming/share/classes/com/sun/jndi/ldap/LdapSchemaCtx.java line 389: > 387: } > 388: > 389: static final private class SchemaInfo { Move private to the front? ------------- Changes requested by redestad (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3078