On Thu, 25 Mar 2021 07:27:58 GMT, Kim Barrett <[email protected]> wrote:

> Please review this change to OopStorage to allow the MEMFLAGS value for 
> associated allocations to be specified when the storage object is 
> constructed.  This allows a subsystem that needs an OopStorage object to 
> associate its allocation with others for that subsystem in NMT tracking and 
> reporting.
> 
> Testing:
> mach5 tier1.
> Manually compared NMT output before and after this change for a test that 
> generated a lot of one particular OopStorage entries.

Looks good. Just one nit

src/hotspot/share/gc/shared/oopStorage.inline.hpp line 28:

> 26: #define SHARE_GC_SHARED_OOPSTORAGE_INLINE_HPP
> 27: 
> 28: #include "memory/allocation.hpp"

Sort order

-------------

Marked as reviewed by stefank (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3188

Reply via email to