On Wed, 31 Mar 2021 08:23:24 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
>> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8264484: Replace uses of StringBuffer with StringBuilder in >> jdk.hotspot.agent >> >> remove redundant local variables as suggested by reviewers > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VMVersionMismatchException.java > line 40: > >> 38: ". Target VM is " + targetVersion; >> 39: return msg; >> 40: } > > Why don't you return `msg` directly? I think `msg` is not needed. > I saw similar codes in other places. inlined ------------- PR: https://git.openjdk.java.net/jdk/pull/3275
