On Wed, 31 Mar 2021 20:07:50 GMT, Lois Foltan <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fifix comment
>
> src/hotspot/share/prims/jvm.cpp line 950:
>
>> 948: InstanceKlass* ik = NULL;
>> 949: if (!is_hidden) {
>> 950: ClassLoadInfo cl_info(protection_domain);
>
> Minor comment, you could pull the creation of ClassLoadInfo out of this if
> statement since both the the if and the else sections create a ClassLoadInfo
> with pretty much the same information.
That other ClassLoadInfo cl_info(protection_domain) you see is from another
function, so I can't pull it out.
The other side of the 'if' statement creates a ClassLoadInfo with all the
hidden class goodies.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3289
