On Mon, 5 Apr 2021 20:50:30 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comments
>
> test/hotspot/jtreg/serviceability/sa/sadebugd/DebugdRmidTest.java line 51:
>
>> 49: JDKToolLauncher rmidLauncher =
>> JDKToolLauncher.createUsingTestJDK("rmid");
>> 50:
>> rmidLauncher.addToolArg("-J-Dsun.rmi.activation.execPolicy=none");
>> 51: rmidLauncher.addToolArg("-J--add-modules=jdk.hotspot.agent");
>
> Is this really needed? Although SA will be using rmid, I don't understand why
> rmid needs to know about SA.
They are needed.
If we don't give `execPolicy=none`, we can see warning on console.
SA code would run on rmid, so we need to add module.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3233
