On Wed, 31 Mar 2021 06:37:00 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into SuspendInHandshake >> - 8257831: Suspend with handshake (review baseline) > > src/hotspot/share/runtime/thread.cpp line 1442: > >> 1440: >> 1441: // The careful dance between thread suspension and exit is handled >> here: >> 1442: _handshake.thread_exit(); > > I don't like the fact this hides the set_terminating call. > > In fact I think I'd rather keep this in-line rather than tucking it away > inside the handshake code. This looks too much like we're informing the > handshake that the thread is exiting rather then coordinating thread > termination with a late suspension request. The problem is that we need access to the private _lock to coordinate this. ------------- PR: https://git.openjdk.java.net/jdk/pull/3191
