On Fri, 9 Apr 2021 15:29:30 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains six commits: >> >> - White space fixes >> - Merge branch 'master' into SuspendInHandshake >> - Review fixes >> - Merge branch 'master' into SuspendInHandshake >> - Merge branch 'master' into SuspendInHandshake >> - 8257831: Suspend with handshake (review baseline) > > src/hotspot/share/runtime/handshake.cpp line 632: > >> 630: } >> 631: >> 632: void HandshakeState::self_suspened() { > > Typo: s/self_suspened/self_suspended/ I'm not fond of `self_suspended` as the function name. Perhaps `do_self_suspend` or something like that... (What color would you like that bike shed?) ------------- PR: https://git.openjdk.java.net/jdk/pull/3191