On 14/04/2021 2:59 am, Daniel D.Daugherty wrote:
On Tue, 13 Apr 2021 11:57:36 GMT, Robbin Ehn <r...@openjdk.org> wrote:
Robbin Ehn has updated the pull request incrementally with two additional
commits since the last revision:
- Obsolete unused flags
- Review fixes 3
Still thumbs up.
I only looked at the v06 incremental webrev.
src/hotspot/share/runtime/arguments.cpp line 525:
523: { "FlightRecorder", JDK_Version::jdk(13),
JDK_Version::undefined(), JDK_Version::undefined() },
524: { "SuspendRetryCount", JDK_Version::jdk(16),
JDK_Version::jdk(17), JDK_Version::jdk(18) },
525: { "SuspendRetryDelay", JDK_Version::jdk(16),
JDK_Version::jdk(17), JDK_Version::jdk(18) },
I think both 'jdk(16)' values here need to be 'jdk(17)' since
we didn't deprecate these option in JDK16. Or they might
need to be 'JDK_Version::undefined()' since we didn't
deprecate these options before obsoleting them.
@dholmes-ora will know for sure.
It should be set to undefined() as they were never deprecated.
Thanks,
David
-------------
Marked as reviewed by dcubed (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3191
