On Wed, 21 Apr 2021 21:22:50 GMT, Daniel D. Daugherty <dcu...@openjdk.org>
wrote:
>> I'm updating the runtime/Thread/SuspendAtExit.java test:
>>
>> - switch from java.lang.Thread.suspend() to JVM/TI SuspendThread()
>> - switch from java.lang.Thread.resume() to JVM/TI ResumeThread()
>> - switch from counter-based to time-based testing
>> - improve error checking since we're now using an API with error codes!
>>
>> I've used this test to stress @robehn's fix for JDK-8257831 using both
>> invocation styles for 9 hours each in {fastdebug, release, slowdebug}
>> configs without any issues.
>>
>> I've run the updated test thru Mach5 Tier[134567] testing; one timeout
>> was observed in a single Tier6 run on Win-X64. I believe this is a case of
>> a lost Thread.interrupt() call.
>
> Daniel D. Daugherty has updated the pull request incrementally with one
> additional commit since the last revision:
>
> dholmes CR changes.
Marked as reviewed by dholmes (Reviewer).
I managed to lose my review comment when switching between commits :) so I'll
add it here.
Updates look good. I agree there is no need for the Thread[] any more.
Thanks,
David
test/hotspot/jtreg/runtime/Thread/SuspendAtExit.java line 38:
> 36: private final static String AGENT_LIB = "SuspendAtExit";
> 37: private final static int DEF_TIME_MAX = 30; // default max # secs to
> test
> 38: private final static int N_THREADS = 32;
N_THREADS is unused now.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3576
