On Thu, 22 Apr 2021 20:10:43 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> This bug was introduced by my recent changes for >> [JDK-8265028](https://bugs.openjdk.java.net/browse/JDK-8265028), which >> attempted to speed up ThreadNode lookups by not looking in the >> runningThreads list if the TLS lookup failed. At the time it was thought >> that the thread could not possibly be on the list, but it turns out >> sometimes it can. >> >> For now I'm just doing a quick fix to replace the assert being triggered >> with a lookup instead, which is pretty much how it worked before >> JDK-8265028. However, I eventually want to get back to not having to do the >> lookup, but first I need to better understand why this is happening in the >> first place, and the tests are failing too often to wait for that, thus the >> quick fix. > > src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 261: > >> 259: */ >> 260: if ( node == NULL ) { >> 261: if (list == NULL || list == &runningThreads ) { > > nit - s/ )/)/ In that case, this one is inconsistent. ------------- PR: https://git.openjdk.java.net/jdk/pull/3634
